Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPERIMENTS] Quota rejection and it's impact on server latencies #1115

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

[EXPERIMENTS] Quota rejection and it's impact on server latencies #1115

wants to merge 26 commits into from

Commits on Aug 11, 2024

  1. Threadpool for quota 

    no flush in quota enforcement handler

Use separate thread pool for quota rejected request's response
    @sushantmane
    sushantmane committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    a419089 View commit details
    Browse the repository at this point in the history

  2. Revert "Threadpool for quota" 

    This reverts commit a419089.
    @sushantmane
    sushantmane committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    a1c3d34 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Add netty stats

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    01f42b1 View commit details
    Browse the repository at this point in the history

  2. Add server connection stats

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b6bcb3e View commit details
    Browse the repository at this point in the history

  3. Change log level to debug for ServerConnectionStatsHandler

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    57d08e8 View commit details
    Browse the repository at this point in the history

  4. rename sensors

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    596c71e View commit details
    Browse the repository at this point in the history

  5. Measure writeAndFlushTime for quota rejected requests

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    37cb75b View commit details
    Browse the repository at this point in the history

  6. Add metrics for ResponseWriteAndFlushTimeForDataRequest

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8d3accf View commit details
    Browse the repository at this point in the history

  7. Fix broken code

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    efd1489 View commit details
    Browse the repository at this point in the history

  8. Add queuedTasksForReadHandler

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    16b70bd View commit details
    Browse the repository at this point in the history

  9. Add time spent in read handler

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    49a9c8f View commit details
    Browse the repository at this point in the history

  10. Add elapsed time

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    21e6f69 View commit details
    Browse the repository at this point in the history

  11. Introduce write and flush handoff pool

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    0e89b97 View commit details
    Browse the repository at this point in the history

  12. Revert "Introduce write and flush handoff pool" 

    This reverts commit 0e89b97.
    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b210502 View commit details
    Browse the repository at this point in the history

  13. Add back FlushConsolidationHandler

    @sushantmane
    sushantmane committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    1e9fab0 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. reduce flush consolidation to 16

    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e736e00 View commit details
    Browse the repository at this point in the history

  2. Update connection stats

    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    25a916d View commit details
    Browse the repository at this point in the history

  3. Add recordTimeSpentInQuotaEnforcement

    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    78e4f45 View commit details
    Browse the repository at this point in the history

  4. Skip flush in quota

    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    09039a6 View commit details
    Browse the repository at this point in the history

  5. Disable flush in channelReadCompletd

    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    edae8d4 View commit details
    Browse the repository at this point in the history

  6. Revert "Disable flush in channelReadCompletd" 

    This reverts commit edae8d4.
    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8fd262e View commit details
    Browse the repository at this point in the history

  7. Revert "Skip flush in quota" 

    This reverts commit 09039a6.
    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    950083f View commit details
    Browse the repository at this point in the history

  8. Use expensive handlers only for acl and quota

    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e9fb60f View commit details
    Browse the repository at this point in the history

  9. Revert "Use expensive handlers only for acl and quota" 

    This reverts commit e9fb60f.
    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    536ee95 View commit details
    Browse the repository at this point in the history

  10. [server][router] Replace synchronized with CAS in TokenBucket::update… 

    … to reduce contention

Use old nextUpdateTimeVal in refillCount
    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d8c5aaa View commit details
    Browse the repository at this point in the history

  11. Delete unnecessary set

    @sushantmane
    sushantmane committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d99fafd View commit details
    Browse the repository at this point in the history