Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Rewrite gRPC read Service to align with Netty-Based HTTP Server #1163

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[server] Rewrite gRPC read Service to align with Netty-Based HTTP Server #1163

wants to merge 13 commits into from

Commits on Sep 15, 2024

  1. - Refactored the Netty handler to enable code reuse for gRPC handlers… 

    … - Added

missing APIs to the gRPC service to close feature gaps with the HTTP
implementation.  - Fixed the gRPC I/O request path threading model: previously,
requests were handled by the gRPC executor thread pool, but now they are
processed by the `StorageReadExecutor` thread pool for better performance.  -
Deprecated the old `get` and `multiGet` gRPC services, which relied on a single
schema and encouraged tightly coupled code. This refactor paves the way for
implementing server-side streaming support for batch get requests more easily.
- Simplified the request processing logic by replacing the chain of
responsibility pattern with a single processor class.
    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    f31c00f View commit details
    Browse the repository at this point in the history

  2. Move responseObserver ops in a mutex

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    efcd9d8 View commit details
    Browse the repository at this point in the history

  3. Address Felix's comments: 7

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    b5a93f3 View commit details
    Browse the repository at this point in the history

  4. Cleanup StatsHandler: It’s better to ask for forgiveness than to ask … 

    …for permission. ^_^
    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    42a71bb View commit details
    Browse the repository at this point in the history

  5. Add unit tests for ServerAdminAction & GrpcUtilsTest

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    ae0d241 View commit details
    Browse the repository at this point in the history

  6. Stats cleanup

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    f355f76 View commit details
    Browse the repository at this point in the history

  7. Fix venice-common cc issue

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    7847976 View commit details
    Browse the repository at this point in the history

  8. Move request stats recording to a single place

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    d84e6ad View commit details
    Browse the repository at this point in the history

  9. Add comments

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    5a2bda1 View commit details
    Browse the repository at this point in the history

  10. Add ut for: BinaryResponseTest, Health check gRPC

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    7ce9a1b View commit details
    Browse the repository at this point in the history

  11. Rename .getStatsRecorder() to .getReadResponseStatsRecorder()

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    e7479b5 View commit details
    Browse the repository at this point in the history

  12. Add unit tests for new gRPC APIs

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    f1e94cf View commit details
    Browse the repository at this point in the history

  13. Add unit tests for GrpcIoRequestProcessor

    @sushantmane
    sushantmane committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    8ae1141 View commit details
    Browse the repository at this point in the history