Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vpj][common][dvc] Minor logging change #1193

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[vpj][common][dvc] Minor logging change #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-client/src/main/java/com/linkedin/davinci/kafka/consumer/KafkaStoreIngestionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,8 @@ public void updatePartitionOffsetRecords(String topicName, int partition, ByteBu
LOGGER.error(
"Caught exception when deserializing offset record byte array: {} for replica: {}",
Arrays.toString(offsetRecordByteArray),
Utils.getReplicaId(topicName, partition));
Utils.getReplicaId(topicName, partition),
sixpluszero marked this conversation as resolved.
Show resolved Hide resolved
e);
throw e;
}
storageMetadataService.put(topicName, partition, offsetRecord);
Expand Down
8 changes: 5 additions & 3 deletions clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,8 @@ private void validateInputDataSchema(String inputDataSchemaString) {
} catch (Exception e) {
if (pushJobSetting.extendedSchemaValidityCheckEnabled) {
LOGGER.error(
"The schema of the input data failed strict Avro schema validation. Verify if the schema is a valid Avro schema.");
"The schema of the input data failed strict Avro schema validation. Verify if the schema is a valid Avro schema.",
e);
updatePushJobDetailsWithCheckpoint(PushJobCheckpoints.EXTENDED_INPUT_DATA_SCHEMA_VALIDATION_FAILED);
throw new VeniceException(e);
}
Expand All @@ -1046,7 +1047,8 @@ private void validateInputDataSchema(String inputDataSchemaString) {
AvroSchemaParseUtils.parseSchemaFromJSONLooseValidation(inputDataSchemaString);
} catch (Exception looseValidationException) {
LOGGER.error(
"The schema of the input data failed loose Avro schema validation. Verify if the schema is a valid Avro schema.");
"The schema of the input data failed loose Avro schema validation. Verify if the schema is a valid Avro schema.",
looseValidationException);
updatePushJobDetailsWithCheckpoint(PushJobCheckpoints.INPUT_DATA_SCHEMA_VALIDATION_FAILED);
throw new VeniceException(looseValidationException);
}
Expand Down Expand Up @@ -2031,7 +2033,7 @@ void validateValueSchema(
if (getValueSchemaIdResponse.isError() && !schemaAutoRegisterFromPushJobEnabled) {
MultiSchemaResponse response = controllerClient.getAllValueSchema(setting.storeName);
if (response.isError()) {
LOGGER.error("Failed to fetch all value schemas, so they will not be printed.");
LOGGER.error("Failed to fetch all value schemas, so they will not be printed. " + response.getError());
} else {
LOGGER.info("All currently registered value schemas:");
for (MultiSchemaResponse.Schema schema: response.getSchemas()) {
Expand Down
2 changes: 1 addition & 1 deletion internal/venice-common/src/main/java/com/linkedin/venice/writer/VeniceWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ public VeniceWriter(
OPEN_VENICE_WRITER_COUNT.incrementAndGet();
heartBeatMessage = generateHeartbeatMessage(checkSumType);
} catch (Exception e) {
logger.error("VeniceWriter cannot be constructed with the props: {}", props);
logger.error("VeniceWriter cannot be constructed with the props: {}", props, e);
throw new VeniceException("Error while constructing VeniceWriter for store name: " + topicName, e);
}
}
Expand Down
Loading