[WIP][controller] Add instance stoppable check based on CV states #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| HelixCustomizedViewOfflinePushRepository customizedViewRepo = resources.getCustomizedViewRepository(); | ||
| ReadWriteStoreRepository storeRepo = getHelixVeniceClusterResources(cluster).getStoreMetadataRepository(); | ||
|
|
||
| for (String instanceId: instances) { |
There was a problem hiding this comment.
Can we unify the logic b/w this and node_removable checks? That one already has the functionality of to_be_stopped_instances through LOCKED_STORAGE_NODE_IDS
There was a problem hiding this comment.
May be not in this PR. node_removable does not use CV and calling it in aggregate over a batch of instances require internal logic change.
There was a problem hiding this comment.
We can still abstract the main functionality into one method, and call it from two places. node_removable can pass a single-element-list to this new function.
Also, this method can accept a RoutingDataRepository, and stoppable-check can pass CV repo while node_removable can pass EV repo
added 5 commits
September 26, 2024 10:45
majisourav99
force-pushed
the
remobable
branch
from
68738b6
to
119d700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instance stoppable check based on CV states
Implement customized server stoppable check API in controller
The customized stoppable check takes a list of instances, along with a list of previously approved instances and decide which of these instances can be stopped.
For the instances that cannot be stopped, the controller returns an enum that denotes the reason for rejecting the request
{WILL_LOSE_DATA, MIN_ACTIVE_REPLICA_VIOLATION, ONGOING_MAINTENANCE, UNKNOWN_INSTANCE}
How was this PR tested?
Does this PR introduce any user-facing changes?