[controller] Ensure empty string from config doesn't result in an array of an empty string for instance tag list #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay of an empty string
internal/venice-client-common/src/main/java/com/linkedin/venice/utils/VeniceProperties.java
Outdated
Show resolved
Hide resolved
|
Also, this specific change affects almost every component, and not just |
kvargha
changed the title
...e-controller/src/main/java/com/linkedin/venice/controller/VeniceControllerClusterConfig.java
Outdated
Show resolved
Hide resolved
nisargthakkar
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
Currently, if you provide an empty string for
controller.instance.tag.list, it will result in an array that has an empty string as an element. This isn't desirable, because the code would then assign an empty string to an instance's tag list in the controller.This change will make sure that if there is an empty string, it will result in an empty array.
How was this PR tested?
Added a new test case
Does this PR introduce any user-facing changes?