-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[da-vinci] Disabled status reporting when the DaVinci app is still bootstrapping #1203
Open
gaojieliu
wants to merge
9
commits into
linkedin:main
Choose a base branch
from
gaojieliu:bootstrapping_dvc_not_report_new_version_status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[da-vinci] Disabled status reporting when the DaVinci app is still bootstrapping #1203
gaojieliu
wants to merge
9
commits into
linkedin:main
from
gaojieliu:bootstrapping_dvc_not_report_new_version_status
+340
−53
Commits on Sep 27, 2024
-
[da-vinci] Disabled status reporting when the DaVinci app is still bo…
…otstrapping In Prod, we are seeing the bootstrapping nodes are blocking the new push, and this PR disables the status reporting if the app is still bootstrapping. This feature is especially important for DaVinci apps, which are using multiple large stores and bootstrapping from an empty state can take a long time and it can delay the new push significantly.
Configuration menu - View commit details
-
Copy full SHA for ee066f2 - Browse repository at this point
Copy the full SHA ee066f2View commit details -
Added the following enhancements:
1. Subscription won't return if there are still active current version bootstrapping to avoid serving stale current version. 2. Delete the heartbeat entry for the current instance if the instance is bootstrapping to avoid Controller mark the bootstrapping node as crashed, which can fail the new push jobs.
Configuration menu - View commit details
-
Copy full SHA for 379f2bc - Browse repository at this point
Copy the full SHA 379f2bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ce8041 - Browse repository at this point
Copy the full SHA 8ce8041View commit details
Commits on Sep 28, 2024
-
Emit a speical heartbeat timestamp for bootstrapping instances, so th…
…at Controller can ignore the report
Configuration menu - View commit details
-
Copy full SHA for dcb0a6a - Browse repository at this point
Copy the full SHA dcb0a6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31a1df5 - Browse repository at this point
Copy the full SHA 31a1df5View commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d99a2a6 - Browse repository at this point
Copy the full SHA d99a2a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70dd36d - Browse repository at this point
Copy the full SHA 70dd36dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5c7449 - Browse repository at this point
Copy the full SHA e5c7449View commit details -
Configuration menu - View commit details
-
Copy full SHA for 269912a - Browse repository at this point
Copy the full SHA 269912aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.