[vpj][all] Create a new module for offline components to reduce leakage #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisargthakkar
force-pushed
the
hadoopCommon
branch
from
a809f90
to
1efee63
Compare
nisargthakkar
force-pushed
the
hadoopCommon
branch
from
1efee63
to
6b24eac
Compare
|
Who needs to depend on this module besides VPJ? |
haoxu07
approved these changes
Sep 28, 2024
We have an ETL module internally that would benefit from this. This class was originally copied from there into OSS. We plan to release in open-source at some point. It is just a matter of allocating some bandwidth for |
Creating a new module just for the sake of this proprietary ETL depender does not seem quite right... can ETL depend on all of VPJ instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new module for offline components to reduce leakage
Recently, we moved some shared classes into
venice-commonto share common functionality. To do this, we addedhadoop-commonlibrary intovenice-common. However, this leakshadoop-commoninto online components too which is not desired. Moved these classes into avenice-hadoop-commonpackageHow was this PR tested?
GHCI
Does this PR introduce any user-facing changes?