Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vpj][all] Create a new module for offline components to reduce leakage #1205

Merged
merged 1 commit into from
Sep 28, 2024
Merged

[vpj][all] Create a new module for offline components to reduce leakage #1205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clients/venice-push-job/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ dependencies {
exclude module: ':internal:alpini'
}

implementation project(':internal:venice-hadoop-common')

implementation (libraries.avro) {
exclude group: 'org.mortbay.jetty' // jetty 6 conflicts with spark-java used in controller api
}
Expand Down
6 changes: 0 additions & 6 deletions internal/venice-common/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ dependencies {
exclude group: 'com.linkedin.container', module: 'container-eventbus-factory' // Keeping' it clean.
}

implementation (libraries.hadoopCommon) {
// Exclude transitive dependency
exclude group: 'org.apache.avro'
exclude group: 'javax.servlet'
}

implementation project(':clients:venice-thin-client')

implementation libraries.avroUtilCompatHelper
Expand Down
12 changes: 12 additions & 0 deletions internal/venice-hadoop-common/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
dependencies {
implementation project(':internal:venice-common')
implementation libraries.log4j2api
implementation (libraries.hadoopCommon) {
// Exclude transitive dependency
exclude group: 'org.apache.avro'
exclude group: 'javax.servlet'
}

testImplementation platform('org.junit:junit-bom:5.9.1')
testImplementation 'org.junit.jupiter:junit-jupiter'
}
0 ...enice/hadoop/schema/HDFSSchemaSource.java → ...enice/hadoop/schema/HDFSSchemaSource.java
View file
Open in desktop
File renamed without changes.
0 ...in/venice/hadoop/schema/SchemaSource.java → ...in/venice/hadoop/schema/SchemaSource.java
View file
Open in desktop
File renamed without changes.
0 ...e/hadoop/schema/TestHDFSSchemaSource.java → ...e/hadoop/schema/TestHDFSSchemaSource.java
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ include 'services:venice-standalone'
include 'internal:venice-avro-compatibility-test'
include 'internal:venice-client-common'
include 'internal:venice-common'
include 'internal:venice-hadoop-common'
include 'internal:venice-jdk-compatibility-test'
include 'internal:venice-test-common'

Expand Down
Loading