[server] Augment completion report with previous ready to serve state #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change persists into the offset record weather or not this partition originally marked itself as ready to serve. This is then used on restart to determine if a node should report completion or not when coming online. The intention is that when a node is lagged under normal conditions (things like heavy load or some other bad condition), we can still restart the node or do deployments and have the node come up and serve traffic. This is done under the notion that it's generally preferable to be online and serving and stale as opposed to caught up/catching up, but unavailable. This will not impact buffer replay on a version push because a replay won't pass a ready to serve check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[server] Augment completion report with previous ready to serve state
This change persists into the offset record weather or not this partition originally marked itself as ready to serve. This is then used on restart to determine if a node should report completion or not when coming online.
The intention is that when a node is lagged under normal conditions (things like heavy load or some other bad condition), we can still restart the node or do deployments and have the node come up and serve traffic. This is done under the notion that it's generally preferable to be online and serving and stale as opposed to caught up/catching up, but unavailable.
This will not impact buffer replay on a version push because a replay won't pass a ready to serve check.
ALSO
Did some test code cleanup in StoreIngestionTask which had an excessive amount of function overloading. Switched it over to use a config object instead and migrated the code over.
Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?