Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Structure for Figma Variables #30

Merged
merged 7 commits into from
Dec 29, 2023

Conversation

jaalah-akamai
Copy link
Collaborator

@jaalah-akamai jaalah-akamai commented Dec 28, 2023

Description 📝

We needed to update the structure to have the tokens studio plugin create Figma variables more reliably. We grouped the themes and added better names. In addition we needed to update the JSON structure slightly.

Major Changes 🔄

  • Bumped package to v1.2.0
    • Our CI needed some fixing since it ran our publish command before this was merged
  • Added Storybook
    • Global Color Swatches
  • Removed plural Colors and Actions
  • Global, Alias and Component tokens have additional hierarchies for their JSON
  • Updated the Themes & Metadata
    • Dark themes inherit from light, so we only need to provide overrides
  • Added components
    • Appbar
    • Container
    • Table

Testing

  1. yarn generate
  2. Copy dist into project node_modules
  3. Observe changes

Running Storybook

  1. yarn storybook

Screenshot 2023-12-29 at 12 54 53 AM

@jaalah-akamai jaalah-akamai self-assigned this Dec 28, 2023
@jaalah-akamai jaalah-akamai merged commit 325759a into main Dec 29, 2023
1 check passed
@jaalah-akamai jaalah-akamai deleted the figma-variables-to-tokens branch December 29, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants