feat: Provide actual values in typescript definition files #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
In order to provide better type definitions to developers, we want to provide them with the actual values of the tokens, not just what primitive it is.
Major Changes 🔄
sd-transforms
andstyle-dictionary
:moduleResolution: "Bundler"
- to allow package entrypoints to work and for those imports to be resolvedtypescript/es6-declarations
tojavascript/es6
fixed this for non-nested tokenstypeof
. I was able to clean upformatProperties
significantly.Preview 📷
Test
Checkout branch
Run
yarn generate
Ensure nothing is broken and build completes
Run
yarn storybook
Ensure everything renders appropriately there (not all components are listed there yet)