New accent and data visualisation alias tokens #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
approved these changes
Jul 19, 2024
| "0": { | ||
| "value": "0", | ||
| "type": "spacing" | ||
| }, |
There was a problem hiding this comment.
not sure this one is helpful but not a big deal
|
@abailly-akamai @davyd-akamai I regret not catching this earlier as I was out of the office. This update includes a breaking change that was not highlighted with Badges: the Bold property was removed. We need to ensure such changes are clearly communicated next time. |
|
I thought we did not attach badge tokens to components (since they were unfinished). That is why they have a lot of changes, they required an additional alias group of tokens (the same for KPI bar). I agree, next time it should be communicated better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.