fix: expand composite objects and convert rem to px #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
…to fix-px-rem-transform
jaalah-akamai
added a commit
that referenced
this pull request
Sep 13, 2024
* fix: expand composite objects and convert rem to px (#55) Co-authored-by: Davyd Melkon <131438868+davyd-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * Shadow blur value fix * Launch button tokens Default border raduis alias token * Launch split menu button tokens * New "rangeHover" and "activeDateHover" interaction tokens, calendar tokens structure update * New global gradient token and new component tokens for the Appbar and Progress Bar components that use gradients * Add descriptions * Remove extensions from linear gradient * Update branch with latest and fix border radius and linear gradient * Numeric spinner text color property fix * Horizontal stepper structure update Error tag new background token * New tokens for KPI bar: background token, disabled state for KPIs New alias accent disabled token * Update BorderRadius to Radius * Update BorderRadius to Radius --------- Co-authored-by: Jaalah Ramos <125309814+jaalah-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
jaalah-akamai
added a commit
that referenced
this pull request
Sep 18, 2024
* fix: expand composite objects and convert rem to px (#55) Co-authored-by: Davyd Melkon <131438868+davyd-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * Shadow blur value fix * Launch button tokens Default border raduis alias token * Launch split menu button tokens * New "rangeHover" and "activeDateHover" interaction tokens, calendar tokens structure update * New global gradient token and new component tokens for the Appbar and Progress Bar components that use gradients * Add descriptions * Remove extensions from linear gradient * Update branch with latest and fix border radius and linear gradient * Numeric spinner text color property fix * Horizontal stepper structure update Error tag new background token * New tokens for KPI bar: background token, disabled state for KPIs New alias accent disabled token * Update BorderRadius to Radius * Update BorderRadius to Radius --------- Co-authored-by: Jaalah Ramos <125309814+jaalah-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
There was an issue with the previous release where
remvalues were being incorrectly converted topxvalues and all the values for composite objects were being expanded.Additionally, certain properties of the typography object, such as
text-decoration,text-transform, andletter-spacing, were not being generated because the shorthand transformations do not include them.Major Changes 🔄
size/pxtransformationAlias.Typography.Body.Listhad aparagraphSpacingproperty which was not being used, I removed it because I didn't see it in the Figma spec. I'm not even sure what that would map to, margin top/bottom?textCaseandletterSpacingfrom theoverlinetoken. This will now be 3 tokens:@davyd-akamai Alternatively, we could utilize the
Font.Textcase.Uppercasetoken and add a new token for a general line spacing likeFont.LetterSpacingPreview 📷