Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.6.1 - staging → main #57

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Release v2.6.1 - staging → main #57

merged 2 commits into from
Jul 31, 2024

Conversation

jaalah-akamai
Copy link
Collaborator

Description 📝

There was an issue with the previous release where rem values were being incorrectly converted to px values and all the values for composite objects were being expanded.

Additionally, certain properties of the typography object, such as text-decoration, text-transform, and letter-spacing, were not being generated because the shorthand transformations do not include them.

Major Changes 🔄

Added:

  • Enhanced logging for better debugging
  • Added “s-inverted” elevation token for containers that appear above the component
  • Added “Background-overlay” alias token for page dimming (when a modal is active)
  • Introduced global token “global.borderRadius.none”

Fixed:

  • Removed size/px transformation causing units to display as px
  • Corrected Elevation type values to be dropShadow instead of innerShadow
  • Removed expand option causing composite tokens to expand properties into separate tokens

Updated:

  • Moved textCase and letterSpacing from the overline token. This will now be 3 tokens:
$token-alias-typography-heading-overline: 800 0.75rem/1rem 'Nunito Sans';
$token-alias-typography-heading-overline-letter-spacing: 0.023rem;
$token-alias-typography-heading-overline-text-case: uppercase;

Preview 📷

Before After
Screenshot 2024-07-30 at 3 08 32 PM Screenshot 2024-07-30 at 2 50 56 PM

jaalah-akamai and others added 2 commits July 31, 2024 11:16
Co-authored-by: Davyd Melkon <131438868+davyd-akamai@users.noreply.github.com>
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
@davyd-akamai
Copy link
Collaborator

Great simplification of typography tokens! Looks good

Copy link
Collaborator

@davyd-akamai davyd-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes looks good to me!

@jaalah-akamai jaalah-akamai merged commit 228330f into main Jul 31, 2024
2 checks passed
@jaalah-akamai jaalah-akamai deleted the staging branch July 31, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants