tech story: Update packages to address dependabot security concerns #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
force-pushed
the
update-packages
branch
from
ab1dce8
to
3e4234b
Compare
|
Potential updates remaining:
|
| "@storybook/react": "^8.3.0", | ||
| "@storybook/react-vite": "^8.3.0", | ||
| "@storybook/test": "^8.3.0", | ||
| "@storybook/theming": "^8.3.0", |
There was a problem hiding this comment.
I wonder if we could only use one set of storybook dependencies between CM & DLS. (and maybe a couple other packages). DLS is here to stay now, so it could potentially server as a sole provide for some deps (I would only consider devDependencies)
There was a problem hiding this comment.
Yea would be a benefit if we maintain the monorepo approach where we can have one package.json hoisted that's shared across packages.
There was a problem hiding this comment.
👀
Created an internal ticket [M3-8596] for investigating this!
jaalah-akamai
approved these changes
Sep 17, 2024
|
✅ No changes to dist file |
|
@coliu-akamai Thanks for the suggestions above, I'll tackle those in a separate PR. |
coliu-akamai
changed the title
jaalah-akamai
pushed a commit
that referenced
this pull request
Sep 18, 2024
) * remove package json * update packages - will need to upgrade node to fully upgrade @typescript-eslint stuff?? * upgrade node to 18.18 + upgrade typescript/eslint dependencies * update rest of packages that seem safe to update * update node versions for yml files to match updated package.json? hmm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Updates (most) packages to their latest version in order to address the dependabot security concerns. Removes package-lock.json since that is old/not necessary with yarn.lock
Major Changes 🔄
Testing
yarn generatedoesn't result in file differences