Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding automaxproc to auto optimize GOPROC management #225

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

prajwalvathreya
Copy link
Contributor

@prajwalvathreya prajwalvathreya commented Sep 6, 2024

This PR adds the automaxproc library to csi driver

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@prajwalvathreya prajwalvathreya requested review from a team as code owners September 6, 2024 19:32
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 38.54%. Comparing base (46cc901) to head (f8df35e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
main.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   38.66%   38.54%   -0.12%     
==========================================
  Files          24       24              
  Lines        1958     1964       +6     
==========================================
  Hits          757      757              
- Misses       1165     1171       +6     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
komer3
komer3 previously approved these changes Sep 9, 2024
main.go Outdated Show resolved Hide resolved
Co-authored-by: Ashley Dumaine <5779804+AshleyDumaine@users.noreply.github.com>
main.go Outdated Show resolved Hide resolved
Co-authored-by: Ashley Dumaine <5779804+AshleyDumaine@users.noreply.github.com>
main.go Outdated

if maxprocsError != nil {
log.Error(maxprocsError, "Failed to set GOMAXPROCS")
os.Exit(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should necessarily exit if we can't set GOMAXPROCS since that could result in a CrashLoopBackoff where there was none prior without this, but we should keep the error log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. This would introduce a new problem. I'll fix that and push the changes.

@prajwalvathreya prajwalvathreya merged commit c366f37 into main Sep 10, 2024
6 checks passed
@AshleyDumaine AshleyDumaine deleted the add-automaxproc branch September 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants