-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding automaxproc to auto optimize GOPROC management #225
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
- Coverage 38.66% 38.54% -0.12%
==========================================
Files 24 24
Lines 1958 1964 +6
==========================================
Hits 757 757
- Misses 1165 1171 +6
Partials 36 36 ☔ View full report in Codecov by Sentry. |
- made `Klogr` a public variable in `pkg/logger/logger.go` in-order to use it in `main.go`
Co-authored-by: Ashley Dumaine <5779804+AshleyDumaine@users.noreply.github.com>
Co-authored-by: Ashley Dumaine <5779804+AshleyDumaine@users.noreply.github.com>
main.go
Outdated
|
||
if maxprocsError != nil { | ||
log.Error(maxprocsError, "Failed to set GOMAXPROCS") | ||
os.Exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should necessarily exit if we can't set GOMAXPROCS
since that could result in a CrashLoopBackoff where there was none prior without this, but we should keep the error log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. This would introduce a new problem. I'll fix that and push the changes.
This PR adds the automaxproc library to csi driver
General:
Pull Request Guidelines: