Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fix for corrupted PV when statefulset is restarted and pv is moved between nodes #226

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Sep 9, 2024

This PR tracks the bug fix for this issue: #224

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 18 lines in your changes missing coverage. Please review.

Project coverage is 38.58%. Comparing base (c366f37) to head (2f33ed3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/nodeserver.go 0.00% 15 Missing ⚠️
internal/driver/luks.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   38.54%   38.58%   +0.04%     
==========================================
  Files          24       24              
  Lines        1964     1954      -10     
==========================================
- Hits          757      754       -3     
+ Misses       1171     1165       -6     
+ Partials       36       35       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komer3 komer3 changed the title [Fix] WIP: fix for corrupted PV when statefulset is restarted [Fix] fix for corrupted PV when statefulset is restarted Sep 10, 2024
@komer3 komer3 changed the title [Fix] fix for corrupted PV when statefulset is restarted [Fix] fix for corrupted PV when statefulset is restarted (Need to cleanup) Sep 10, 2024
… volume. Previous implementation was unable to find it causing corruption when the encrypted PV was moved between nodes.
@komer3 komer3 marked this pull request as ready for review September 10, 2024 15:24
@komer3 komer3 requested review from a team as code owners September 10, 2024 15:24
@komer3 komer3 changed the title [Fix] fix for corrupted PV when statefulset is restarted (Need to cleanup) [Fix] fix for corrupted PV when statefulset is restarted Sep 10, 2024
@komer3 komer3 changed the title [Fix] fix for corrupted PV when statefulset is restarted [Bug] fix for corrupted PV when statefulset is restarted and pv is moved between nodes Sep 10, 2024
komer3 and others added 3 commits September 11, 2024 13:19
…untSource test cases

- Updated volume ID from "test" to "3232-pvc1234" in NodeUnstageVolumeRequest and NodeUnpublishVolumeRequest tests.
- Added comprehensive test cases for closeLuksMountSource, covering success and error scenarios.
@komer3 komer3 merged commit 5be48b7 into main Sep 11, 2024
6 checks passed
@komer3 komer3 deleted the statefulset-encrypt-pv-fix branch September 11, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants