-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] fix for corrupted PV when statefulset is restarted and pv is moved between nodes #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 38.54% 38.58% +0.04%
==========================================
Files 24 24
Lines 1964 1954 -10
==========================================
- Hits 757 754 -3
+ Misses 1171 1165 -6
+ Partials 36 35 -1 ☔ View full report in Codecov by Sentry. |
komer3
changed the title
[Fix] WIP: fix for corrupted PV when statefulset is restarted
[Fix] fix for corrupted PV when statefulset is restarted
Sep 10, 2024
komer3
changed the title
[Fix] fix for corrupted PV when statefulset is restarted
[Fix] fix for corrupted PV when statefulset is restarted (Need to cleanup)
Sep 10, 2024
… volume. Previous implementation was unable to find it causing corruption when the encrypted PV was moved between nodes.
komer3
force-pushed
the
statefulset-encrypt-pv-fix
branch
from
September 10, 2024 15:24
d94b6da
to
aae6f95
Compare
komer3
changed the title
[Fix] fix for corrupted PV when statefulset is restarted (Need to cleanup)
[Fix] fix for corrupted PV when statefulset is restarted
Sep 10, 2024
komer3
changed the title
[Fix] fix for corrupted PV when statefulset is restarted
[Bug] fix for corrupted PV when statefulset is restarted and pv is moved between nodes
Sep 10, 2024
…untSource test cases - Updated volume ID from "test" to "3232-pvc1234" in NodeUnstageVolumeRequest and NodeUnpublishVolumeRequest tests. - Added comprehensive test cases for closeLuksMountSource, covering success and error scenarios.
amold1
approved these changes
Sep 11, 2024
eljohnson92
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the bug fix for this issue: #224
General:
Pull Request Guidelines: