Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use commit sha in GHA for docker image version #250

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

amold1
Copy link
Contributor

@amold1 amold1 commented Sep 17, 2024

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@amold1 amold1 requested review from a team as code owners September 17, 2024 18:07
@amold1 amold1 removed request for a team September 17, 2024 18:07
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.75%. Comparing base (193da12) to head (ba326c3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   40.75%   40.75%           
=======================================
  Files          23       23           
  Lines        1818     1818           
=======================================
  Hits          741      741           
  Misses       1043     1043           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eljohnson92
eljohnson92 previously approved these changes Sep 17, 2024
@amold1 amold1 merged commit acbfe7e into main Sep 17, 2024
6 checks passed
@komer3 komer3 deleted the gha.-ref.update branch September 17, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants