[Feat] Node Server Metrics Implementation #278
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 76.33% 73.84% -2.50%
==========================================
Files 21 22 +1
Lines 1644 1747 +103
==========================================
+ Hits 1255 1290 +35
- Misses 289 356 +67
- Partials 100 101 +1 ☔ View full report in Codecov by Sentry. |
…etheus - implemented metrics storage for `NodePublishVolume` function
- moved functions to a seperate package
- undid changes in main.go
prajwalvathreya
changed the title
- fixed `ineffassign` error for variable `success`
prajwalvathreya
changed the title
komer3
changed the title
internal/driver/server.go
Outdated
| } | ||
|
|
||
| func (s *nonBlockingGRPCServer) Start(endpoint string, ids csi.IdentityServer, cs csi.ControllerServer, ns csi.NodeServer) { | ||
| s.wg.Add(1) | ||
| go s.serve(endpoint, ids, cs, ns) | ||
| go s.startMetricsServer(":8081") |
There was a problem hiding this comment.
Can we make this dynamic and get the value from the ENV var? May be also only enable metric server if a flag is set to true
| SuccessFalse = "false" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
Could you add some comments about these prom metrics? Would be helpful in future when trying to understand this
internal/driver/nodeserver.go
Outdated
| success = metrics.SuccessFalse | ||
| // Record failure metric before returning | ||
| metrics.NodePublishTotal.WithLabelValues(success).Inc() | ||
| metrics.NodePublishDuration.WithLabelValues(success).Observe(time.Since(start).Seconds()) |
There was a problem hiding this comment.
Looks like these lines are being used multiple times, we should consider encapsulating it in some func or var?
There was a problem hiding this comment.
Yes, this makes sense. I have pushed changes to encapsulate this.
…environment variable
This PR is to get the metrics of the functions performed by the node server. The functions for which the metrics are implemented are:
NodePublishVolume
NodeUnpublishVolume
NodeStageVolume
NodeUnstageVolume
NodeExpandVolume
General:
Pull Request Guidelines: