Merge pull request #10700 from linode/staging

Release v1.124.0 - `staging` → `master`

.github/workflows/stale.yml

@@ -0,0 +1,22 @@
+name: 'Stale issue handler'
+
+on:
+  workflow_dispatch: null
+  schedule:
+    - cron: '0 0 * * *'
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v9
+        id: stale
+        with:
+          stale-pr-message: 'This PR is stale because it has been open 15 days with
+            no activity. Please attend to this PR or it will be closed in
+            5 days'
+          days-before-stale: 15
+          days-before-close: 5
+          # Disable issues. We only want this running on PRs.
+          days-before-issue-stale: -1
+          days-before-issue-close: -1

docs/CONTRIBUTING.md

@@ -29,7 +29,7 @@ Feel free to open an issue to report a bug or request a feature.
 6. Open a pull request against `develop` and make sure the title follows the same format as the commit message.
 7. If needed, create a changeset to populate our changelog
     - If you don't have the Github CLI installed or need to update it (you need GH CLI 2.21.0 or greater),
-        - install it via `brew`: https://cli.github.com/manual/installation or upgrade with `brew upgrade gh`
+        - install it via `brew`: https://github.com/cli/cli#installation or upgrade with `brew upgrade gh`
         - Once installed, run `gh repo set-default` and pick `linode/manager` (only > 2.21.0)
         - You can also just create the changeset manually, in this case make sure to use the proper formatting for it.
     - Run `yarn changeset`from the root, choose the package to create a changeset for, and provide a description for the change.

docs/development-guide/13-coding-standards.md

@@ -11,7 +11,7 @@ We use [ESLint](https://eslint.org/) to enforce coding and formatting standards.
 - **prettier** (code formatting)
 - **scanjs** (security)
 
-If you are using VSCode it is highly recommended to use the ESlint extension. The Prettier extension is also recommended, as it can be configured to format your code on save.
+If you are using VSCode it is **highly** recommended to use the [ESlint extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint). The [Prettier extension](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) is also recommended, as it can be configured to format your code on save.
 
 ## React
 

packages/api-v4/CHANGELOG.md

@@ -1,3 +1,15 @@
+## [2024-07-22] - v0.122.0
+
+### Changed:
+
+- Breaking: change Placement Group `affinity_type` to `placement_group_type` ([#10651](https://github.com/linode/manager/pull/10651))
+- Breaking: change Placement Group `is_strict` to `placement_group_policy` ([#10651](https://github.com/linode/manager/pull/10651))
+- Use new "lish" API instead of "lish_token" ([#10656](https://github.com/linode/manager/pull/10656))
+
+### Upcoming Features:
+
+- Add ACLG Config and Widget to CloudPulse types ([#10625](https://github.com/linode/manager/pull/10625))
+
 ## [2024-07-08] - v0.121.0
 
 ### Changed:

packages/api-v4/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@linode/api-v4",
-  "version": "0.121.0",
+  "version": "0.122.0",
   "homepage": "https://github.com/linode/manager/tree/develop/packages/api-v4",
   "bugs": {
     "url": "https://github.com/linode/manager/issues"

packages/api-v4/src/account/types.ts

@@ -61,9 +61,9 @@ export type BillingSource = 'linode' | 'akamai';
 
 export type AccountCapability =
   | 'Akamai Cloud Load Balancer'
-  | 'CloudPulse'
   | 'Block Storage'
   | 'Cloud Firewall'
+  | 'CloudPulse'
   | 'Disk Encryption'
   | 'Kubernetes'
   | 'Linodes'
@@ -72,6 +72,7 @@ export type AccountCapability =
   | 'Managed Databases'
   | 'NodeBalancers'
   | 'Object Storage Access Key Regions'
+  | 'Object Storage Endpoint Types'
   | 'Object Storage'
   | 'Placement Group'
   | 'Support Ticket Severity'
@@ -257,7 +258,8 @@ export type NotificationType =
   | 'promotion'
   | 'user_email_bounce'
   | 'volume_migration_scheduled'
-  | 'volume_migration_imminent';
+  | 'volume_migration_imminent'
+  | 'tax_id_invalid';
 
 export type NotificationSeverity = 'minor' | 'major' | 'critical';
 
@@ -433,6 +435,7 @@ export const EventActionKeys = [
   'tag_create',
   'tag_delete',
   'tax_id_invalid',
+  'tax_id_valid',
   'tfa_disabled',
   'tfa_enabled',
   'ticket_attachment_upload',

packages/api-v4/src/cloudpulse/types.ts

@@ -43,3 +43,19 @@ export interface Filters {
   operator: string;
   value: string;
 }
+
+export interface AclpConfig {
+  dashboardId: number;
+  interval: string;
+  region: string;
+  resources: string[];
+  timeDuration: string;
+  widgets: { [label: string]: AclpWidget };
+}
+
+export interface AclpWidget {
+  aggregateFunction: string;
+  timeGranularity: TimeGranularity;
+  label: string;
+  size: number;
+}

packages/api-v4/src/linodes/linodes.ts

@@ -13,7 +13,7 @@ import Request, {
 } from '../request';
 import { DeepPartial, Filter, Params, ResourcePage as Page } from '../types';
 import { Volume } from '../volumes/types';
-import { CreateLinodeRequest, Linode } from './types';
+import { CreateLinodeRequest, Linode, LinodeLishData } from './types';
 
 /**
  * getLinode
@@ -29,17 +29,15 @@ export const getLinode = (linodeId: number) =>
   );
 
 /**
- * getLinodeLishToken
+ * getLinodeLish
  *
- * Generates a token which can be used to authenticate with LISH.
+ * Generates urls and websockets protocols to authenticate with LISH.
  *
  * @param linodeId { number } The id of the Linode.
  */
-export const getLinodeLishToken = (linodeId: number) =>
-  Request<{ lish_token: string }>(
-    setURL(
-      `${API_ROOT}/linode/instances/${encodeURIComponent(linodeId)}/lish_token`
-    ),
+export const getLinodeLish = (linodeId: number) =>
+  Request<LinodeLishData>(
+    setURL(`${API_ROOT}/linode/instances/${encodeURIComponent(linodeId)}/lish`),
     setMethod('POST')
   );
 

packages/api-v4/src/linodes/types.ts

@@ -526,3 +526,10 @@ export interface DeleteLinodeConfigInterfacePayload {
   configId: number;
   interfaceId: number;
 }
+
+export interface LinodeLishData {
+  weblish_url: string;
+  glish_url: string;
+  monitor_url: string;
+  ws_protocols: string[];
+}

packages/api-v4/src/placement-groups/types.ts

@@ -1,29 +1,34 @@
 import type { Region } from '../regions/types';
 
-export const AFFINITY_TYPES = {
+export const PLACEMENT_GROUP_TYPES = {
   'affinity:local': 'Affinity',
   'anti_affinity:local': 'Anti-affinity',
 } as const;
 
-export type AffinityType = keyof typeof AFFINITY_TYPES;
-export type AffinityTypeEnforcement = 'Strict' | 'Flexible';
+export const PLACEMENT_GROUP_POLICIES = {
+  strict: 'Strict',
+  flexible: 'Flexible',
+} as const;
+
+export type PlacementGroupType = keyof typeof PLACEMENT_GROUP_TYPES;
+export type PlacementGroupPolicy = keyof typeof PLACEMENT_GROUP_POLICIES;
 
 export interface PlacementGroup {
   id: number;
   label: string;
   region: Region['id'];
-  affinity_type: AffinityType;
+  placement_group_type: PlacementGroupType;
   is_compliant: boolean;
   members: {
     linode_id: number;
     is_compliant: boolean;
   }[];
-  is_strict: boolean;
+  placement_group_policy: PlacementGroupPolicy;
 }
 
 export type PlacementGroupPayload = Pick<
   PlacementGroup,
-  'id' | 'label' | 'affinity_type' | 'is_strict'
+  'id' | 'label' | 'placement_group_type' | 'placement_group_policy'
 >;
 
 export interface CreatePlacementGroupPayload

packages/manager/CHANGELOG.md

@@ -4,6 +4,63 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2024-07-22] - v1.124.0
+
+### Added:
+
+- Account Limit support ticket form for limit errors in Linode Create flow ([#10620](https://github.com/linode/manager/pull/10620))
+
+### Changed:
+
+- Use `getRestrictedResourceText` utility and move restrictions Notice to top of Volume Create ([#10632](https://github.com/linode/manager/pull/10632))
+- Update Placement Group affinity labels and nomenclature ([#10651](https://github.com/linode/manager/pull/10651))
+- Use new "lish" API instead of "lish_token" ([#10656](https://github.com/linode/manager/pull/10656))
+- Display overflowing Kubernetes cluster tags in drawer ([#10658](https://github.com/linode/manager/pull/10658))
+- Rename Distribution to OS ([#10666](https://github.com/linode/manager/pull/10666))
+- Improve LKE Detail summary panel and Node Pool tables UI ([#10685](https://github.com/linode/manager/pull/10685))
+- Disable Create Volume Button on the landing page for restricted users ([#10627](https://github.com/linode/manager/pull/10627))
+- Disable Volume Action Menu buttons for restricted users ([#10641](https://github.com/linode/manager/pull/10641))
+- Disable Create Volume button on empty state landing page for restricted users ([#10630](https://github.com/linode/manager/pull/10630))
+- Disable Create Image button on empty state landing page for restricted users ([#10670](https://github.com/linode/manager/pull/10670))
+- Disable Create Image button on landing page for restricted users ([#10671](https://github.com/linode/manager/pull/10671))
+
+### Fixed:
+
+- Incorrect error notice in Volume drawers for restricted users ([#10646](https://github.com/linode/manager/pull/10646))
+- Github CLI install link in Contributing guide ([#10657](https://github.com/linode/manager/pull/10657))
+- LKE details page 'Delete Pool' button misalignment ([#10660](https://github.com/linode/manager/pull/10660))
+- User Preferences not properly being cached when the app loads ([#10663](https://github.com/linode/manager/pull/10663))
+- Blank toast notification when canceling an image upload ([#10664](https://github.com/linode/manager/pull/10664))
+- Missing support link in some toast notifications ([#10680](https://github.com/linode/manager/pull/10680))
+- Column headers for Automatic Images ([#10696](https://github.com/linode/manager/pull/10696))
+
+### Removed:
+
+- Gravatar analytics events ([#10661](https://github.com/linode/manager/pull/10661))
+
+### Tech Stories:
+
+- Improve `getQueryParamsFromQueryString` type safety ([#10645](https://github.com/linode/manager/pull/10645))
+- Improve API flexibility for `useToastNotification` ([#10654](https://github.com/linode/manager/pull/10654))
+- Clean up and fix Linode Details styles ([#10662](https://github.com/linode/manager/pull/10662))
+- Improve PowerActionsDialog ([#10667](https://github.com/linode/manager/pull/10667))
+- Replace Select with Autocomplete component on Kubernetes Create page ([#10673](https://github.com/linode/manager/pull/10673))
+- Update Managed Queries to use Query Key Factory ([#10679](https://github.com/linode/manager/pull/10679))
+
+### Tests:
+
+- Add Cypress integration test to add SSH key via Linode Create ([#10448](https://github.com/linode/manager/pull/10448))
+- Add Cypress test for Login History page ([#10575](https://github.com/linode/manager/pull/10575))
+- Add tests for Longview client rename and deletion ([#10644](https://github.com/linode/manager/pull/10644))
+
+### Upcoming Features:
+
+- Add Tax ID Notifications & Warning Icon ([#10558](https://github.com/linode/manager/pull/10558))
+- Add capability to save & retrieve user preferences ([#10625](https://github.com/linode/manager/pull/10625))
+- Add feature flag and capability for OBJ Gen2 ([#10647](https://github.com/linode/manager/pull/10647))
+- Add Analytics Events to Linode Create v2 ([#10649](https://github.com/linode/manager/pull/10649))
+- Update Manage Image Regions drawer based on UX feedback ([#10674](https://github.com/linode/manager/pull/10674))
+
 ## [2024-07-08] - v1.123.0
 
 ### Added: