Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade to latest DLS 2.6.1 #10734

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Jul 31, 2024

Description 📝

This new version does not include any new features for our current use but contains fixes for tokens that we may potentially want to use. See linode/design-language-system#57 for more details

Changes 🔄

N/A

Target release date 🗓️

N/A

Preview 📷

N/A

How to test 🧪

Verification steps

  • Ensure Cloud Manager maintains current overall design look / feel.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai jaalah-akamai added the Dependencies Pull requests that update a dependency file label Jul 31, 2024
@jaalah-akamai jaalah-akamai self-assigned this Jul 31, 2024
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner July 31, 2024 16:13
@jaalah-akamai jaalah-akamai requested review from dwiley-akamai and AzureLatte and removed request for a team July 31, 2024 16:13
Copy link

github-actions bot commented Jul 31, 2024

Coverage Report:
Base Coverage: 82.37%
Current Coverage: 82.37%

@@ -18,7 +18,7 @@
"@emotion/styled": "^11.11.0",
"@hookform/resolvers": "2.9.11",
"@linode/api-v4": "*",
"@linode/design-language-system": "^2.6.0",
"@linode/design-language-system": "^2.6.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set this to * similar to the other linode packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because this package lives outside of manager. Also we don't have great testing in place yet for DLS to ensure breaking changes aren't introduced.

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conducted visual audit of the app and did not observe any UI bugs ✅

Copy link
Contributor

@AzureLatte AzureLatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jaalah-akamai jaalah-akamai merged commit a6be9ab into linode:develop Jul 31, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants