-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Upgrade to latest DLS 2.6.1 #10734
Conversation
Coverage Report: ✅ |
@@ -18,7 +18,7 @@ | |||
"@emotion/styled": "^11.11.0", | |||
"@hookform/resolvers": "2.9.11", | |||
"@linode/api-v4": "*", | |||
"@linode/design-language-system": "^2.6.0", | |||
"@linode/design-language-system": "^2.6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set this to *
similar to the other linode packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because this package lives outside of manager. Also we don't have great testing in place yet for DLS to ensure breaking changes aren't introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conducted visual audit of the app and did not observe any UI bugs ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description 📝
This new version does not include any new features for our current use but contains fixes for tokens that we may potentially want to use. See linode/design-language-system#57 for more details
Changes 🔄
N/A
Target release date 🗓️
N/A
Preview 📷
N/A
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply