Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Provide user preference option for redacting sensitive data #10972

Closed
wants to merge 6 commits into from

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Sep 19, 2024

Description 📝

This is a WIP.

  • Inspired by:
    • The DatabaseSummaryConnectionDetails show/hide password
    • A desire to speed up the PR description process and stop cropping out data we commonly don't want to make public for security (e.g. IPs, phone number on account)
      • Could just be toggleable in the MSW 2.0
  • Also potentially helpful to surface for customers, so it lives on http://localhost:3000/profile/settings for now

Changes 🔄

List any change relevant to the reviewer.

  • ...
  • ...

Target release date 🗓️

Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Header Header
Cell Screenshot 2024-09-17 at 2 06 34 PM
Cell Screenshot 2024-09-17 at 2 06 51 PM
Cell Screenshot 2024-09-17 at 2 11 33 PM
Cell Screenshot 2024-09-17 at 2 11 54 PM

How to test 🧪

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mjac0bs mjac0bs self-assigned this Sep 19, 2024
@mjac0bs
Copy link
Contributor Author

mjac0bs commented Sep 20, 2024

I'm going to close this POC after demoing to the team, and I'll reopen it once it's been run by Product and I've incorporated feedback - will be a couple of weeks.

@mjac0bs mjac0bs closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant