Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8704] - Disable Create Firewall button with tooltip text on Landing Page for restricted users #11094

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hasyed-akamai
Copy link
Contributor

Description 📝

To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.

Here, we are restricting users from creating new Firewalls from the Landing Page when they do not have access or have read only access.

Changes 🔄

List any change relevant to the reviewer.

  • For restricted users:
    • Disabled Create Firewall Button on the Landing Page

Target release date 🗓️

Preview 📷

Before After
Before After

How to test 🧪

Prerequisites

  • Log into two accounts side by side:
    • An unrestricted admin user account: full access
    • A restricted user account (use Incognito for this)
      • Start with Read Only for everything

Reproduction steps

  • Landing:
    • Observe as restricted user, notice shows and you cannot create Firewall

Verification steps

  • After changes, observe tooltips are tailored to the action.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai requested a review from a team as a code owner October 14, 2024 16:23
@hasyed-akamai hasyed-akamai requested review from bnussman-akamai and jaalah-akamai and removed request for a team October 14, 2024 16:23
Copy link

Coverage Report:
Base Coverage: 86.97%
Current Coverage: 86.97%

@hasyed-akamai hasyed-akamai added Ready for Review Restricted User Access Improve UX surrounding restricted access to features labels Oct 14, 2024
@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Ready for Review Restricted User Access Improve UX surrounding restricted access to features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants