Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [CT-3888] - Update API docs endpoint links to style matching linode/linode-docs-theme#400 #9691

Closed
wants to merge 1 commit into from

Conversation

nmelehan
Copy link
Contributor

@nmelehan nmelehan commented Sep 15, 2023

Description 📝

https://github.com/linode/linode-docs-theme/pull/400 will update the API docs so that every endpoint is rendered to its own page, instead of an endpoint collection rendering all of its endpoints to a single page. URLs for API docs will change like so:

Before:
https://www.linode.com/docs/api/images/#image-upload
After:
https://www.linode.com/docs/api/images/image-upload/

This manager PR updates the one API docs link I could find that links to an individual endpoint within a collection.

Note that if a user visits one of the old-style anchor links for endpoint, there is client-side logic to refresh the page to show the new URL. This uses some JS to update the page's contents and the URL of the browser, instead of performing an actual page reload.

Please do not merge until we push the API docs changes to production.

Major Changes 🔄

Just the one URL change noted in the description

Preview 📷

No visual changes

How to test 🧪

Doesn't seem like testing is needed

@nmelehan nmelehan requested a review from a team as a code owner September 15, 2023 23:10
@nmelehan nmelehan requested review from hana-akamai and carrillo-erik and removed request for a team September 15, 2023 23:10
@nmelehan nmelehan changed the title Update anchor-linked API docs URLs to match linode/linode-docs-theme#400 docs: [CT-3888] - Update API docs endpoint links to style matching linode/linode-docs-theme#400 Sep 15, 2023
@jdamore-linode jdamore-linode added Wait to Merge Documentation Improving / adding to our documentation labels Sep 18, 2023
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nmelehan!

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Will this improve the performance of the API docs?

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Sep 22, 2023
@bnussman-akamai
Copy link
Member

Closing due to inactivity. Feel free to reopen if linode/docs#6615 makes progress!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Documentation Improving / adding to our documentation Wait to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants