tree: read all attributes from sysfs when available #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
force-pushed
the
tree-no-cmd
branch
2 times, most recently
from
ca2faf1
to
abcb0f9
Compare
This was referenced Dec 8, 2023
tbzatek
reviewed
Dec 8, 2023
The kernel already exposes parts or all attributes we are looking up with the ns id command. By reading these from the sysfs we can remove the last command we are issuing during the topology scan. Signed-off-by: Daniel Wagner <dwagner@suse.de>
The fd is not needed anymore if the kernel exposes all necessary sysfs entries to fully scan the nvme subsystem. Thus do not alwyas open the blk device and do it only when necessary. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel already exposes parts or all attributes we are looking up
with the ns id command. By reading these from the sysfs we can remove
the last command we are issuing during the topology scan.
Depends on: https://lore.kernel.org/linux-nvme/20231218165954.29652-1-dwagner@suse.de/
Fixes: #681 #550