example: fix mi identify failed with error cntid #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk-ozlabs
suggested changes
Feb 8, 2024
This command failed when we try to identify a controller that the controller id is 1. Refer to the `Figure 273: Identify - CNS Values`: +-----------+-------+ | CNS Value | CNTID | +-----------+-------+ | 01h | N | +-----------+-------+ When CNS is 01h, the CNTID field is ignored. See `Figure 270: Identify - Command Dword 10`: If this field is not used as part of the Identify operation, then * host software shall clear this field to 0h for backwards compatibility (0h is a valid controller identifier); * and the controller shall ignore this field. This filed is set to controller id in the example code, but it should be 0 when CNS is 1. PS: The NVMe that we are testing does not ignore the CNTID field and returns an error when the CNTID field is not 0. Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
zhangjian3032
force-pushed
the
dev-example-fix-mi-identify-error
branch
from
9da7ce1
to
67f4e8a
Compare
jk-ozlabs
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command failed when we try to identify a controller that the controller id is 1.
Refer to the
Figure 273: Identify - CNS Values:+-----------+-------+
| CNS Value | CNTID |
+-----------+-------+
| 01h | N |
+-----------+-------+
When CNS is 01h, the CNTID field is ignored.
See
Figure 270: Identify - Command Dword 10:If this field is not used as part of the Identify operation, then
This filed is set to controller id in the example code, but it should be 0 when CNS is 1.
PS: The NVMe that we are testing does not ignore the CNTID field and returns an error when the CNTID field is not 0.