Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent TLS keys #783

Closed
wants to merge 10 commits into from
Closed

Persistent TLS keys #783

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
addda06
linux: add nvme_read_key()
hreinecke Feb 21, 2024
2a4e211
linux: add nvme_export_tls_key()
hreinecke Feb 21, 2024
f1c040e
linux: add nvme_import_tls_key()
hreinecke Feb 21, 2024
cb4b944
linux: rework nvme_insert_tls_key_versioned()
hreinecke Feb 21, 2024
8b533ae
linux: allow for NULL argument in nvme_lookup_keyring()
hreinecke Feb 21, 2024
26a67f8
tree: read TLS key in nvme_configure_ctrl()
hreinecke Feb 21, 2024
c9c57a3
json: export TLS key in PSK interchange format
hreinecke Feb 21, 2024
501aaf7
json: import TLS key from PSK interchange format
hreinecke Feb 21, 2024
776318f
config-schema.json: tls keys and keyrings are strings
hreinecke Feb 21, 2024
beaa3c9
fabrics: keyring is a long
hreinecke Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions doc/config-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,14 @@
"description": "Controller DH-HMAC-CHAP key",
"type": "string"
},
"keyring": {
"description": "Keyring for TLS key lookup",
"type": "string"
},
"tls_key": {
"description": "TLS key for the connection",
"type": "string"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes should be in config-schema.json.in

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course.

"nr_io_queues": {
"description": "Number of I/O queues",
"type": "integer"
Expand Down Expand Up @@ -156,14 +164,6 @@
"type": "boolean",
"default": false
},
"keyring": {
"description": "Keyring for TLS key lookup",
"type": "integer"
},
"tls_key": {
"description": "TLS key for the connection",
"type": "integer"
},
"tls": {
"description": "Enable TLS encryption",
"type": "boolean",
Expand Down