sysfs: Export NVMe controller sysfs directory return function #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path is returned with the controller name by the nvme scan. To return the path without the nvme scan nvme identify namespace. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
I am not sure if we really need to do this. The sysfs is always mounted under Is there any good use case for nvme-cli for this, e.g. do you want to add also some unit tests for nvme-cli which would rely on a sysfs mock? For this purpose I'd say it could make sense. So I tend to say no to this PR if we don't have a good use case why we should export it. |
|
Okay I will do consider separately if the sysfs access functionality can be moved and combined from the nvme-cli to libnvme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path is returned with the controller name by the nvme scan. To return the path without the nvme scan nvme identify namespace.