types: Fix EOM header optional data present fields definition #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: The existing NVME_EOM_EYE_DATA_PRESENT and NVME_EOM_PRINTABLE_EYE_PRESENT macros have been changed. |
There was a problem hiding this comment.
Change seem mostly good to me, though wouldn't removing the original enums cause backwards-compatibility issues?
I'm not sure if this feature is new enough to just do it anyways, or if renaming the macros and fixing but keeping the original definitions would be best.
|
I agree, better leave the old enums around and avoid breakage. Just add a 'deprecated' comment to them. |
Defined eye data present as bit 0 and printable eye present as bit 1. Fixed eye data present to bit 1 and printable eye present to bit 0. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Also add reserved filed definition and macros to get. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
Thanks for your review comments. Just fixed the patch as mentioned. |
bpaupore-wdc
approved these changes
Mar 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined eye data present as bit 0 and printable eye present as bit 1. Fixed eye data present to bit 1 and printable eye present to bit 0. Add the optional data present reserved filed definition and macros to get.