type: Add NVME_CMBEBS property definitions #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Apr 15, 2024
src/nvme/types.h
Outdated
| @@ -491,6 +491,30 @@ enum nvme_cmbsts { | |||
|
|
|||
| #define NVME_CMBSTS_CBAI(cmbsts) NVME_GET(cmbsts, CMBSTS_CBAI) | |||
|
|
|||
| enum nvme_unit { | |||
| NVME_UNIT_B, | |||
There was a problem hiding this comment.
Since these are types with fixed values, it's better to explicit assign them the values, e.g. NVME_UNIT_B = 1 as we do in the other types.
There was a problem hiding this comment.
Fixed as mentioned. Thank you.
Also add NVME_UNIT definitions for CMBSZU and PMRSZU. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Also change PMRSWTU to use NVME_UNIT definitions. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add NVME_UNIT definitions for CMBSZU and PMRSZU.