Change commit order on release #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no user of the release variable, thus remove it. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Previously, we updated the docs after the commit so that any version string in the docs are correct. But there are none, thus we can update the docs before doing the release. This makes the release look a bit more natural. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's reorder the release commits, so that the last commit is actually the version string update. The only reason for the previous order was the version string was used in the documentation. Though there are none, only the date is used.
Fixes: #832