tree: fix segfault in nvme_free_tree() #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands like nvme list & list-subsys currently segfault for --help or any invalid command option as shown below: nvme list -h Usage: nvme list <device> [OPTIONS] Retrieve basic information for all NVMe namespaces Options: [ --verbose, -v ] --- output verbosity [ --output-format=<FMT>, -o <FMT> ] --- format: normal|json|binary Segmentation fault (core dumped) This is due to an invalid dereferencing of the nvme_root_t object in nvme_free_tree(). Fix this by checking whether this object is valid before dereferencing and freeing it. And while we are it, ensure r->options is also valid before freeing it. Signed-off-by: Martin George <marting@netapp.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands like nvme list & list-subsys currently segfault for --help or any invalid command option as shown below:
nvme list -h
Usage: nvme list [OPTIONS]
Retrieve basic information for all NVMe namespaces
Options:
[ --verbose, -v ] --- output verbosity
[ --output-format=, -o ] --- format: normal|json|binary
Segmentation fault (core dumped)
This is due to an invalid dereferencing of the nvme_root_t object in nvme_free_tree(). Fix this by checking whether this object is valid before dereferencing and freeing it. And while we are it, ensure r->options is also valid before freeing it.