Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnvme: add lockdown log page support(LID : 0x14) #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ankitvvsoni
Copy link
Contributor

Adding command APIs for inband, out of band, structures and enums for lockdown log page (LID : 0x14).

@ankitvvsoni ankitvvsoni force-pushed the lockdown_log branch 2 times, most recently from 4ad08d3 to 4ac95a0 Compare September 18, 2024 13:39
Copy link
Collaborator

@igaw igaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same naming updates needed, rest looks good.

src/nvme/types.h Outdated Show resolved Hide resolved
src/nvme/types.h Outdated Show resolved Hide resolved
src/nvme/types.h Outdated Show resolved Hide resolved
adding command APIs for inband, out of band, structures and enums
for lockdown log page (LID : 0x14).

Signed-off-by: Ankit Soni <soni.ankit@samsung.com>
@ankitvvsoni
Copy link
Contributor Author

@igaw, addressed review comments.

@ankitvvsoni
Copy link
Contributor Author

hi @igaw ,
Changes you have suggested are addressed. can you provide your review?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants