Skip to content

Commit

Permalink
nvme-print-stdout: fix ASQB, ACQB and BMBBA prints
Browse files Browse the repository at this point in the history
The fields needed be output only as the 52 most significant bits.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
  • Loading branch information
ikegami-t committed May 1, 2024
1 parent 2f49845 commit 87d79bb
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions nvme-print-stdout.c
Original file line number Diff line number Diff line change
Expand Up @@ -1227,6 +1227,16 @@ static void stdout_registers_aqa(__u32 aqa)
printf("\tAdmin Submission Queue Size (ASQS): %u\n\n", NVME_AQA_ASQS(aqa) + 1);
}

static void stdout_registers_asq(uint64_t asq)
{
printf("\tAdmin Submission Queue Base (ASQB): %"PRIx64"\n", (uint64_t)NVME_ASQ_ASQB(asq));
}

static void stdout_registers_acq(uint64_t acq)
{
printf("\tAdmin Completion Queue Base (ACQB): %"PRIx64"\n", (uint64_t)NVME_ACQ_ACQB(acq));
}

static void stdout_registers_cmbloc(__u32 cmbloc, bool support)
{
static const char * const enforced[] = { "Enforced", "Not Enforced" };
Expand Down Expand Up @@ -1321,7 +1331,8 @@ static void stdout_registers_bprsel(__u32 bprsel)

static void stdout_registers_bpmbl(uint64_t bpmbl)
{
printf("\tBoot Partition Memory Buffer Base Address (BMBBA): %"PRIx64"\n", bpmbl);
printf("\tBoot Partition Memory Buffer Base Address (BMBBA): %"PRIx64"\n",
(uint64_t)NVME_BPMBL_BMBBA(bpmbl));
}

static void stdout_registers_cmbmsc(uint64_t cmbmsc)
Expand Down Expand Up @@ -1453,10 +1464,10 @@ static void stdout_ctrl_register_human(int offset, uint64_t value, bool support)
stdout_registers_aqa(value);
break;
case NVME_REG_ASQ:
printf("\tAdmin Submission Queue Base (ASQB): %#"PRIx64"\n\n", value);
stdout_registers_asq(value);
break;
case NVME_REG_ACQ:
printf("\tAdmin Completion Queue Base (ACQB): %#"PRIx64"\n\n", value);
stdout_registers_acq(value);
break;
case NVME_REG_CMBLOC:
stdout_registers_cmbloc(value, support);
Expand Down

0 comments on commit 87d79bb

Please sign in to comment.