Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme: Use libnvme sysfs function to get NVMe controller directory #2255

Closed
wants to merge 1 commit into from

Conversation

ikegami-t
Copy link
Contributor

Also delete the SYS_NVME definition unused instead.

Also delete the SYS_NVME definition unused instead.

Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
@ikegami-t
Copy link
Contributor Author

Depended on the libnvme PR changes linux-nvme/libnvme#801.

@igaw
Copy link
Collaborator

igaw commented Apr 9, 2024

As I wrote in PR I think we need a good reason for making sysfs configurable in nvme-cli. libnvme has unit tests which rely on it. But for nvme-cli we don't have those and for this particular function here it's not going to work because of the mmap operation.

@ikegami-t
Copy link
Contributor Author

Okay I see. Understood as the sysfs functions purpose is differrent for the patch since I though just change nvme-cli not use the sysfs paths directly but libnvme provides them. I will do consider this more later but anyway let me close the PR. Thank you for your reviewing and comments.

@ikegami-t ikegami-t closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants