Initialize logging for commands #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems |
Yes this is a possibility. Let me play with it and see how this works out. |
|
depends on linux-nvme/libnvme#824 |
ikegami-t
reviewed
Apr 26, 2024
ikegami-t
reviewed
Apr 26, 2024
Import nvme_init_default_logging. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Use a cleanup helper for the nvme_root_t objects which simplifies the error paths and ensures we are always removing all the allocated resources. Signed-off-by: Daniel Wagner <dwagner@suse.de>
The library will only print errors unless we initialize default logging. By doing so, all nvme commands are enabled to also print debug information. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only initialize the libnvme logging for those commands which use the
nvme_root_tobject. In order to get the logging going for all commands we have to initialize the logging for every command.This is a first attempt to solve this. Maybe it would be better to initialize the libvnme logging just once for all commands.
For this draft I'v just made it work for the
readandwritecommand (submit_io).