Use C99 types for uint32_t #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For completeness, I've submitted linux-nvme/libnvme#838 too. |
<stdint.h> provides `uint32_t`, while `u_int_32` is an unofficial/internal typedef that glibc happens to provide. This fixes the build on musl. Bug: https://bugs.gentoo.org/931194 Signed-off-by: Sam James <sam@gentoo.org>
`u_char` is not a standard name for `unsigned char` and may not work; some implementations may provide it for convenience. Signed-off-by: Sam James <sam@gentoo.org>
|
added prefix to commit subject |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<stdint.h> provides
uint32_t, whileu_int_32is an unofficial/internal typedef that glibc happens to provide. This fixes the build on musl.Bug: https://bugs.gentoo.org/931194