Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme: add support to revoke TLS key #2387

Merged
merged 14 commits into from
Jul 9, 2024
Merged

Commits on Jul 5, 2024

  1. build: bump libnvme wrap

    Fetch nvme_revoke_tls_key.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0ad8a1a View commit details
    Browse the repository at this point in the history
  2. nvme: use stdout for exporting TLS keys

    The export command should use stdout as default output as documentation
    claims. Furthermore, it should open the keyfile to write in write mode.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f0ce6a0 View commit details
    Browse the repository at this point in the history
  3. nvme: strip newline when parsing TLS key files

    When exporting a TLS keys from the kernel keyring a line might have a
    newline. Strip the newline away as the nvme_import_tls_key is not
    expecting it and thus fails to load an exported keyfile.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a5673bb View commit details
    Browse the repository at this point in the history
  4. nvme: use cleanup helper for STREAM objects

    The tls_key function is using a STREAM object and closes it when leaving
    the context. Update it to use the helper.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a5fbeda View commit details
    Browse the repository at this point in the history
  5. fabrics: use cleanup helper for STREAM objects

    discover_from_conf_file uses a STREAM. Let's use the cleanup helper to
    close it.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    efca565 View commit details
    Browse the repository at this point in the history
  6. nvme-rpmb: use cleanup helper for STREAM objects

    write_file uses a STREAM. Let's use the cleanup helper to close it.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a4b1764 View commit details
    Browse the repository at this point in the history
  7. nvme: use cleanup helper to close file descriptor

    io_mgmt_send uses a file descriptor. Let's use the cleanup helper to
    close it.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    32308ce View commit details
    Browse the repository at this point in the history
  8. nvme: factor out import key function

    Split the command line option handling code from the operation.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    015ad41 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. nvme: return error code/message for TLS commands

    Propagate error codes for TLS commands. Also print an error message when
    scanning TLS keys.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6b01d08 View commit details
    Browse the repository at this point in the history
  2. nvme: add support to revoke TLS key

    Add support to nvme-cli to revoke TLS keys from a keyring.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fcdd203 View commit details
    Browse the repository at this point in the history
  3. build: sort documentation files entries

    Sort the file names alphabetically.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    93c5d13 View commit details
    Browse the repository at this point in the history
  4. doc: fix tls-key --keyfile shorthand

    The shorthand for --keyfile is -f and not -k.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bdc7792 View commit details
    Browse the repository at this point in the history
  5. doc: add tls-key --revoke documentation

    Add the --revoke option to the tls-key documentation.
    
    While at it, add examples how to use it.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    98f7952 View commit details
    Browse the repository at this point in the history
  6. completion: add support for tls-key

    The tls-key command is missing support for the zsh and bash completion.
    
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    igaw committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    01857f5 View commit details
    Browse the repository at this point in the history