Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Added solidigm plugin commands #2514

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

lgdacunh
Copy link
Contributor

Added documentation to all current solidigm plugin commands

@lgdacunh
Copy link
Contributor Author

@igaw , checkpatch review is complaining I added files. What should I do to make this check happy?

@igaw
Copy link
Collaborator

igaw commented Sep 30, 2024

checkpatch.pl is a bit picky when adding/removing files. You can ignore this warning.

You also need to add the documentation files to meson.build in order to get them build/installed.

Added documentation to all current solidigm plugin commands

Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
@lgdacunh
Copy link
Contributor Author

lgdacunh commented Oct 1, 2024

checkpatch.pl is a bit picky when adding/removing files. You can ignore this warning.

You also need to add the documentation files to meson.build in order to get them build/installed.

Done!

@igaw igaw merged commit bed5550 into linux-nvme:master Oct 2, 2024
17 of 18 checks passed
@igaw
Copy link
Collaborator

igaw commented Oct 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants