DAT-18263: sonar lint related changes, cleaned up unused imports

liquibase · Sep 27, 2024 · d2ec7b3 · d2ec7b3
1 parent 96396f3
commit d2ec7b3
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 16 deletions.
diff --git a/src/main/java/liquibase/ext/databricks/change/AbstractAlterPropertiesChangeDatabricks.java b/src/main/java/liquibase/ext/databricks/change/AbstractAlterPropertiesChangeDatabricks.java
@@ -44,17 +44,13 @@ public ValidationErrors validate(Database database) {
     protected abstract String getNoPropertiesErrorMessage();
 
     protected String applySubjectToErrorPattern(String subject) {
-        return MessageFormat.format("Alter %s Properties change require 'setExtendedTableProperties' or 'unsetExtendedTableProperties' element, please add at least one option.", capitalize(subject));
+        return MessageFormat.format("Alter {0} Properties change require 'setExtendedTableProperties' or 'unsetExtendedTableProperties' element, please add at least one option.", capitalize(subject));
     }
 
-    public abstract String getConfirmationMessage();
-
     protected String getConfirmationMessage(String elementName) {
         return MessageFormat.format("{0}.{1}.{2} successfully altered.", getCatalogName(), getSchemaName(), elementName);
     }
 
-    public abstract SqlStatement[] generateStatements(Database database);
-
     protected SqlStatement[] generateStatements(AbstractAlterPropertiesStatementDatabricks statement) {
         if (setExtendedTableProperties != null) {
             statement.setSetExtendedTableProperties(setExtendedTableProperties);

diff --git a/...main/java/liquibase/ext/databricks/change/AbstractAlterPropertiesStatementDatabricks.java b/...main/java/liquibase/ext/databricks/change/AbstractAlterPropertiesStatementDatabricks.java
@@ -15,7 +15,7 @@ public abstract class AbstractAlterPropertiesStatementDatabricks extends Abstrac
     private SetExtendedTableProperties setExtendedTableProperties;
     private UnsetExtendedTableProperties unsetExtendedTableProperties;
 
-    public AbstractAlterPropertiesStatementDatabricks(String catalogName, String schemaName) {
+    protected AbstractAlterPropertiesStatementDatabricks(String catalogName, String schemaName) {
         this.catalogName = catalogName;
         this.schemaName = schemaName;
     }

diff --git a/...base/ext/databricks/change/alterTableProperties/AlterTablePropertiesChangeDatabricks.java b/...base/ext/databricks/change/alterTableProperties/AlterTablePropertiesChangeDatabricks.java
@@ -4,8 +4,6 @@
 import liquibase.change.DatabaseChangeProperty;
 import liquibase.database.Database;
 import liquibase.ext.databricks.change.AbstractAlterPropertiesChangeDatabricks;
-import liquibase.ext.databricks.change.AbstractAlterPropertiesStatementDatabricks;
-import liquibase.ext.databricks.change.alterViewProperties.AlterViewPropertiesStatementDatabricks;
 import liquibase.ext.databricks.database.DatabricksDatabase;
 import liquibase.servicelocator.PrioritizedService;
 import liquibase.statement.SqlStatement;
@@ -15,7 +13,7 @@
 @DatabaseChange(name = "alterTableProperties", description = "Alter Table Properties", priority = PrioritizedService.PRIORITY_DATABASE + 500)
 public class AlterTablePropertiesChangeDatabricks extends AbstractAlterPropertiesChangeDatabricks {
 
-    private final static String CHANGE_TYPE_SUBJECT = "Table";
+    private static final String CHANGE_TYPE_SUBJECT = "Table";
     private String tableName;
 
     @Override

diff --git a/...e/ext/databricks/change/alterTableProperties/AlterTablePropertiesStatementDatabricks.java b/...e/ext/databricks/change/alterTableProperties/AlterTablePropertiesStatementDatabricks.java
@@ -1,7 +1,6 @@
 package liquibase.ext.databricks.change.alterTableProperties;
 
 import liquibase.ext.databricks.change.AbstractAlterPropertiesStatementDatabricks;
-import liquibase.statement.AbstractSqlStatement;
 import lombok.Getter;
 import lombok.Setter;
 

diff --git a/...uibase/ext/databricks/change/alterViewProperties/AlterViewPropertiesChangeDatabricks.java b/...uibase/ext/databricks/change/alterViewProperties/AlterViewPropertiesChangeDatabricks.java
@@ -4,7 +4,6 @@
 import liquibase.change.DatabaseChangeProperty;
 import liquibase.database.Database;
 import liquibase.ext.databricks.change.AbstractAlterPropertiesChangeDatabricks;
-import liquibase.ext.databricks.change.AbstractAlterPropertiesStatementDatabricks;
 import liquibase.ext.databricks.database.DatabricksDatabase;
 import liquibase.servicelocator.PrioritizedService;
 import liquibase.statement.SqlStatement;
@@ -14,7 +13,7 @@
 @DatabaseChange(name = "alterViewProperties", description = "Alter View Properties", priority = PrioritizedService.PRIORITY_DATABASE + 500)
 public class AlterViewPropertiesChangeDatabricks extends AbstractAlterPropertiesChangeDatabricks {
 
-    private final static String CHANGE_TYPE_SUBJECT = "View";
+    private static final String CHANGE_TYPE_SUBJECT = "View";
     private String viewName;
 
     @Override

diff --git a/...ase/ext/databricks/change/alterViewProperties/AlterViewPropertiesStatementDatabricks.java b/...ase/ext/databricks/change/alterViewProperties/AlterViewPropertiesStatementDatabricks.java
@@ -1,9 +1,6 @@
 package liquibase.ext.databricks.change.alterViewProperties;
 
 import liquibase.ext.databricks.change.AbstractAlterPropertiesStatementDatabricks;
-import liquibase.ext.databricks.change.alterTableProperties.SetExtendedTableProperties;
-import liquibase.ext.databricks.change.alterTableProperties.UnsetExtendedTableProperties;
-import liquibase.statement.AbstractSqlStatement;
 import lombok.Getter;
 import lombok.Setter;
 

diff --git a/...in/java/liquibase/ext/databricks/sqlgenerator/AlterViewPropertiesGeneratorDatabricks.java b/...in/java/liquibase/ext/databricks/sqlgenerator/AlterViewPropertiesGeneratorDatabricks.java
@@ -2,7 +2,6 @@
 
 import liquibase.database.Database;
 import liquibase.exception.ValidationErrors;
-import liquibase.ext.databricks.change.alterTableProperties.AlterTablePropertiesStatementDatabricks;
 import liquibase.ext.databricks.change.alterViewProperties.AlterViewPropertiesStatementDatabricks;
 import liquibase.ext.databricks.database.DatabricksDatabase;
 import liquibase.sql.Sql;