DAT-18204: fix concurrent runs #156
Conversation
sayaliM0412
changed the title
.github/workflows/lth.yml
Outdated
| # ensure only one run or job within the group runs at a time. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
strategy:
max-parallel: 1
was working fine. I think the issues is when a matrix jobs fails and the schema is not correctly removed.
There was a problem hiding this comment.
we do have this step here to ensure removal of the test schema even if one or more matrix jobs fail. : https://github.com/liquibase/liquibase-databricks/blob/main/.github/workflows/lth.yml#L73 destroying the schema
There was a problem hiding this comment.
Nice but it seems it does not destroy the endpoint, see https://github.com/liquibase/liquibase-databricks/actions/runs/10009689797/job/27669131489#step:11:14, also cancel-in-progress: true will abort TH jobs. The team would have to manually re-run the canceled ones, right? If the infra is not removed then all jobs will fail.
There was a problem hiding this comment.
right, I was looking at a way to destroy the resources if creation fails as the resources already exists, but TF doesnt have the context and therefore shows "No changes" : tested here: https://github.com/liquibase/liquibase-databricks/actions/runs/10081580514/job/27873923161#step:6:12. I have set cancel-in-progress: false for the same reason.
.github/workflows/lth.yml
Outdated
| # ensure only one run or job within the group runs at a time. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Nice but it seems it does not destroy the endpoint, see https://github.com/liquibase/liquibase-databricks/actions/runs/10009689797/job/27669131489#step:11:14, also cancel-in-progress: true will abort TH jobs. The team would have to manually re-run the canceled ones, right? If the infra is not removed then all jobs will fail.
…rkflow can be in progress at a time.
|
feat:
.github/workflows/lth.yml: use workflow_dispatch to run manually and fix concurrent runs issue