Skip to content

Commit

Permalink
Merge pull request #18 from liquibase/sonar-fix
Browse files Browse the repository at this point in the history
chore: fix sonar execution
  • Loading branch information
filipelautert authored Apr 30, 2024
2 parents c60f817 + e28d8fe commit e1b2b6c
Show file tree
Hide file tree
Showing 3 changed files with 63 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
environment: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository && 'external' || 'internal' }}
runs-on: ubuntu-latest
steps:
- run: true
- run: "true"

build-test:
needs: authorize
Expand All @@ -23,3 +23,7 @@ jobs:
with:
java: "[ 17, 21 ]"

dependabot:
needs: build-test
uses: liquibase/build-logic/.github/workflows/dependabot-automerge.yml@v0.7.5
secrets: inherit
8 changes: 8 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
<sonar.scm.provider>git</sonar.scm.provider>
<sonar.qualitygate.wait>true</sonar.qualitygate.wait>
<sonar.sources>src/main/java</sonar.sources>
<sonar.tests>src/test/java</sonar.tests>
</properties>

<dependencies>
Expand All @@ -57,6 +59,12 @@
<artifactId>liquibase-core</artifactId>
<version>4.27.0</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>2.0.13</version>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package com.example.change;

import liquibase.statement.core.CreateTableStatement;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;

class PrefixedCreateTableChangeTest {

private PrefixedCreateTableChange prefixedCreateTableChange;

@BeforeEach
void setUp() {
prefixedCreateTableChange = new PrefixedCreateTableChange();
}

@Test
void getPrefix_returnsNull_whenNotSet() {
assertNull(prefixedCreateTableChange.getPrefix());
}

@Test
void getPrefix_returnsPrefix_whenSet() {
String expectedPrefix = "testPrefix";
prefixedCreateTableChange.setPrefix(expectedPrefix);

assertEquals(expectedPrefix, prefixedCreateTableChange.getPrefix());
}

@Test
void generateCreateTableStatement_usesStandardPrefix_whenPrefixNotSet() {
prefixedCreateTableChange.setTableName("testTable");

CreateTableStatement statement = prefixedCreateTableChange.generateCreateTableStatement();

assertTrue(statement.getTableName().startsWith("standard_"));
}

@Test
void generateCreateTableStatement_usesSetPrefix_whenPrefixSet() {
String expectedPrefix = "testPrefix";
prefixedCreateTableChange.setPrefix(expectedPrefix);
prefixedCreateTableChange.setTableName("testTable");

CreateTableStatement statement = prefixedCreateTableChange.generateCreateTableStatement();

assertTrue(statement.getTableName().startsWith(expectedPrefix + "_"));
}
}

0 comments on commit e1b2b6c

Please sign in to comment.