Database#getLineComment mustn't throw an exception
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was a last-minute change before merging PR #25 and we didn't spot this: all tests are failing due to this as this is being called by the constructor of `ChangeLogParameters`. instead of returning something artifical (like `//`) which doesn't apply here we'll just return an empty string. this is needed until liquibase adds first-class support for NoSQL DBs and removes any SQL-specific features (requires liquibase/liquibase#4236).
|
note: the integration tests were not executed, thus we didn't spot this. reported this in #48 |
|
reta
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was a last-minute change before merging PR #25 and we didn't spot this: all tests are failing due to this as this is being called by the constructor of
ChangeLogParameters.instead of returning something artifical (like
//) which doesn't apply here we'll just return an empty string. this is needed until liquibase adds first-class support for NoSQL DBs and removes any SQL-specific features (requires liquibase/liquibase#4236).