Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database#getLineComment mustn't throw an exception #49

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Commits on Sep 19, 2024

  1. Database#getLineComment mustn't throw an exception

    this was a last-minute change before merging PR #25 and we didn't spot
    this: all tests are failing due to this as this is being called by the
    constructor of `ChangeLogParameters`.
    
    instead of returning something artifical (like `//`) which doesn't apply
    here we'll just return an empty string. this is needed until liquibase
    adds first-class support for NoSQL DBs and removes any SQL-specific
    features (requires liquibase/liquibase#4236).
    rursprung committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7533202 View commit details
    Browse the repository at this point in the history