Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson doesn't use specified submodule for libgit2. #81

Open
adamharrison opened this issue Feb 25, 2024 · 3 comments
Open

Meson doesn't use specified submodule for libgit2. #81

adamharrison opened this issue Feb 25, 2024 · 3 comments

Comments

@adamharrison
Copy link
Member

adamharrison commented Feb 25, 2024

When I compile with meson, I get:

../src/lpm.c:318:16: error: ‘GIT_OID_SHA1_SIZE’ undeclared (first use in this function); did you mean ‘GIT_OID_RAWSZ’?
  318 |   if (length < GIT_OID_SHA1_SIZE*2) {
      |                ^~~~~~~~~~~~~~~~~

Presumably because it's using the system version. Can we default this to the submodule version, @Guldoman, @Jan200101 ?

@Guldoman
Copy link
Member

Sure, I can make it use the submodules by default and add an option to force using the system versions.

@adamharrison
Copy link
Member Author

👍

@Jan200101
Copy link
Contributor

this commit changed GIT_OID_RAWSZ to GIT_OID_SHA1_SIZE
libgit2/libgit2@dbc4ac1
the earliest tag with it included is v1.6.1

According to the debian tracker it only has 1.5.1 in stable, ouch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants