WoW Classic Support

[chowarth]

I've gone through and tried to get as much working as I possibly can. (this may will be a bit hacky as I have zero experience with Lua or the WoW API), most things were checks to see if an object exists before trying to use it.

It is by no means perfect I've only gone through everything while using a Warrior so there could well be some class specific behaviour that will cause errors.

Hopefully this will help #278

Working:

• !BeautyCase
• !Colorz
• Evl's Raid Status
• nBuff
• nChat
• nCore
• nMainbar (with added 'short' functionality)
• nMinimap
• nTooltip

TODO:

These are a little above my basic understanding of Lua and the WoW API

• nPlates
• nPower
• oUF
• oUF_Neav
• oUF_NeavRaid

[WillScarlettOhara]

Hi ! Thank you very much. I'll check that as a hunter point of vue.

[AFK-afk]

Hi！How to Download this？ I want to test.

[chowarth]

@AFK-afk, the easiest way would be to download the branch from the repo I forked: here

[WillScarlettOhara]

Hi,

When I click on guild icon on top of the minimap, it opens the Group panel instead of guild panel.

Is there a way to apply action bar button border to raid/group unit frame within Vuhdo for example ? Thank you for you work.

[chowarth]

@Leiludallas

1. Had a quick look at the minimap button. It is calling ToggleGuildFrame() but that seems to default to the 'Groups' panel in Classic. I'll see if there's anything I can do to get the actual Guild panel showing instead.
2. I don't use Vuhdo myself but I can have a look. I was thinking of going through and adding configuration settings for the skins as well, so if you don't want something skinned you can easily disable it.

@lithammer @Grimsbain - Any chance a Classic branch could be created and then this could be maintained alongside?

[lithammer]

Sorry for being unresponsive. I actually already have a local 'classic' branch, but I haven't had time to play as much as I'd hoped. Long queue times on Gehennas-EU, I'm still lvl 19 😞

Anyway, I'm currently trying to restore some of the lost functionality like threat, aura durations, real health values, and heal prediction (this is a tougher though). But I've only tested on warlock so far, so I have no idea what the state of things like combo points and totems are.

[chowarth]

I can totally understand with the queues on Gehennas-EU, ended up rolling onto another server rather than try and get on there with old server friends.

If there's anything I can do to help, or if you want to use the changes I've made to everything outside of the unit frames, feel free to shout. Although I'm still fresh to Lua, and writing addons in general, I'm enjoying just digging around at the moment 😄

[WillScarlettOhara]

@Leiludallas

1. Had a quick look at the minimap button. It is calling ToggleGuildFrame() but that seems to default to the 'Groups' panel in Classic. I'll see if there's anything I can do to get the actual Guild panel showing instead.
2. I don't use Vuhdo myself but I can have a look. I was thinking of going through and adding configuration settings for the skins as well, so if you don't want something skinned you can easily disable it.

@lithammer @Grimsbain - Any chance a Classic branch could be created and then this could be maintained alongside?

Thanks for the last fix.

I talk about Vuhdo but if you can change the default wow group and raid frame, it's great too.

[vendethiel]

if _G['UnitHasVehicleUI'] and UnitHasVehicleUI("player") then? (or isRetail and ... for better perf)

[vendethiel]

Potentially:

for k = 3, 8 do
  local editBox = select(k, _G[self.."EditBox"]:GetRegions())
  if editBox.SetTexture then
    editBox:SetTexture(nil)
  end
end

[vendethiel]

also (DressUpModelFrame or DressUpModel):Undress()

[vendethiel]

The first file could export something like IS_CLASSIC = select(4, GetBuildInfo()) == 11302

[lithammer]

There's also a classic branch, but I haven't worked on it for some time. So it might be broken in raids (I'm not even lvl 60) or that some Blizzard patch introduced changes that broke it.