You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue: Access to Decorator Parameters in on_backoff Handlers
Description
Currently, when using backoff decorators like @backoff.on_predicate or @backoff.on_exception, the on_backoff handlers only receive a details dictionary with limited information. However, important decorator parameters, such as max_time and max_tries, are not accessible in the details, which can limit flexibility in implementing complex backoff handling logic. Additionally, there is no direct way to pass additional parameters to on_backoff handlers.
Problem
For use cases where on_backoff handling may need to consider or log values like max_time and max_tries (especially if they are dynamic), users currently need to implement workarounds such as using global variables, environment variables, or functools.partial. These methods, while functional, can make the code less readable and maintainable.
Allowing direct access to decorator parameters like max_time and max_tries within on_backoff handlers would simplify configuration and enhance functionality. Additionally, supporting the option to pass custom parameters into the on_backoff handler would add flexibility for more complex backoff strategies.
Proposed Solution
Include Decorator Parameters in details: Add max_time, max_tries, and other relevant parameters from the decorator into the details dictionary.
Allow Additional Parameters in on_backoff Handlers: Permit on_backoff handlers to accept additional arguments beyond details, enabling more flexible configuration.
Example Usage
@backoff.on_predicate(backoff.runtime,predicate=lambdar: r.status_code==429,on_backoff=lambdadetails, max_time: custom_handler(details, max_time=max_time),max_time=180,max_tries=5)defmy_function():
passdefcustom_handler(details, max_time):
# Access max_time directly in the handlerprint(f"Max time is set to {max_time}")
Benefit
This enhancement would improve flexibility and code readability when working with backoff configurations and would allow more sophisticated use cases to be handled more naturally.
The text was updated successfully, but these errors were encountered:
In our custom function use case, we would like to check if the Retry-After header specifies a wait time that exceeds max_time. If it does, we prefer to skip waiting and immediately return, saving time by not waiting longer than necessary.
Issue: Access to Decorator Parameters in
on_backoff
HandlersDescription
Currently, when using
backoff
decorators like@backoff.on_predicate
or@backoff.on_exception
, theon_backoff
handlers only receive adetails
dictionary with limited information. However, important decorator parameters, such asmax_time
andmax_tries
, are not accessible in thedetails
, which can limit flexibility in implementing complex backoff handling logic. Additionally, there is no direct way to pass additional parameters toon_backoff
handlers.Problem
For use cases where
on_backoff
handling may need to consider or log values likemax_time
andmax_tries
(especially if they are dynamic), users currently need to implement workarounds such as using global variables, environment variables, orfunctools.partial
. These methods, while functional, can make the code less readable and maintainable.Allowing direct access to decorator parameters like
max_time
andmax_tries
withinon_backoff
handlers would simplify configuration and enhance functionality. Additionally, supporting the option to pass custom parameters into theon_backoff
handler would add flexibility for more complex backoff strategies.Proposed Solution
details
: Addmax_time
,max_tries
, and other relevant parameters from the decorator into thedetails
dictionary.on_backoff
Handlers: Permiton_backoff
handlers to accept additional arguments beyonddetails
, enabling more flexible configuration.Example Usage
Benefit
This enhancement would improve flexibility and code readability when working with backoff configurations and would allow more sophisticated use cases to be handled more naturally.
The text was updated successfully, but these errors were encountered: