Merge pull request #2 from livestorm/liv-12186-pipedrive-fix-nomethod…

…error-in-pipedrive-gem-for-non-json

feat(integrations): manage string body response that is not a json, liv-12186

lib/pipedrive/base.rb

@@ -56,12 +56,23 @@ def process_response(res)
     def response_body(json)
       JSON.parse(json)
     rescue StandardError
-      {}
+      if json.present?
+        { body: json }
+      else
+        {}
+      end
     end
 
     def failed_response(res)
-      failed_res = res.body.merge(success: false, not_authorized: false,
-        failed: false).merge(res.headers)
+      failed_res = if res.body.is_a?(::Hashie::Mash)
+        res.body
+      else
+        ::Hashie::Mash.new(response_body(res.body))
+      end
+
+      failed_res.merge!(success: false, not_authorized: false, failed: false)
+      failed_res.merge!(res.headers)
+
       case res.status
       when 401
         failed_res[:not_authorized] = true

spec/lib/pipedrive/base_spec.rb

@@ -41,6 +41,27 @@
       )
     end
 
+    context "when the body is a string" do
+      let(:res) do
+        instance_double(
+          Faraday::Response,
+          body: "Too many requests",
+          status: 429,
+          headers: ::Hashie::Mash.new({foo: :bar})
+        )
+      end
+
+      it "returns an error hash" do
+        expect(subject).to eq(::Hashie::Mash.new({
+          body: "Too many requests",
+          failed: false,
+          not_authorized: false,
+          success: false,
+          foo: :bar,
+        }))
+      end
+    end
+
     context "status is 401" do
       let(:status) { 401 }