Playerbot helper #18
Merged
Playerbot helper #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyunfan1223
reviewed
Aug 1, 2024
| // All in one chat message builder | ||
| static void BuildChatPacket( | ||
| WorldPacket& data, ChatMsg msgtype, std::string_view message, Language language = LANG_UNIVERSAL, PlayerChatTag chatTag = CHAT_TAG_NONE, | ||
| ObjectGuid const& senderGuid = ObjectGuid(), std::string_view senderName = nullptr, |
There was a problem hiding this comment.
/home/ubuntu22/azerothcore-wotlk/src/server/game/Chat/Chat.h:66:88: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
ObjectGuid const& senderGuid = ObjectGuid(), std::string_view senderName = nullptr,
^~~~~~~
/home/ubuntu22/azerothcore-wotlk/src/server/game/Chat/Chat.h:67:88: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
ObjectGuid const& targetGuid = ObjectGuid(), std::string_view targetName = nullptr,
There was a problem hiding this comment.
std::string_view senderName = {} should be okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few helper methods for mod-playerbots to allow channel recovery and chathelper formating / getter