fix the free variable names #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiratara
force-pushed
the
free-variable-context
branch
from
a1b6c05
to
71da7a3
Compare
hiratara
commented
Sep 16, 2023
Comment on lines
+471
to
+472
| // use a different name than bound variables | ||
| from_u32(max_depth + 96 + *i as u32 - depth) |
There was a problem hiding this comment.
Refer to the free variable list while considering depth. Also, avoid using names that might be used for bound variables by using max_depth.
hiratara
force-pushed
the
free-variable-context
branch
from
71da7a3
to
3fdc516
Compare
|
Apologies for not having checked this out yet, I was on vacation. I'll look into it soon, though! |
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that in the current implementation, the free variables are named incorrectly.
For example,
34(λ45)(λλ56)refers to the third and fourth names of the free variable list in each lambda abstraction, but is printed inc d (λa.d e) (λa.λb.e f). It is correct that the free variables within any lambda abstraction are the same, as ine f (λa.e f) (λa.λb.e f).